Update FeeGrant API and test with Gas Station #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f69b598
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0159a5d7.abstract-docs.pages.dev |
| Branch Preview URL: | https://adair-abs-56-rename-grant-fe.abstract-docs.pages.dev |
adairrr
changed the title
adairrr
commented
Aug 28, 2023
Comment on lines
+305
to
+348
| pub trait FeeGranterAllowance { | ||
| fn to_any(&self) -> Any; | ||
| } | ||
|
|
||
| impl FeeGranterAllowance for BasicAllowance { | ||
| fn to_any(&self) -> Any { | ||
| Any { | ||
| type_url: feegrant::v1beta1::BasicAllowance::TYPE_URL.to_string(), | ||
| value: self.clone().to_proto().encode_to_vec(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl FeeGranterAllowance for PeriodicAllowance { | ||
| fn to_any(&self) -> Any { | ||
| Any { | ||
| type_url: feegrant::v1beta1::PeriodicAllowance::TYPE_URL.to_string(), | ||
| value: feegrant::v1beta1::PeriodicAllowance { | ||
| basic: self.basic.clone().map(|b| b.to_proto()), | ||
| period: self.period.map(|p| prost_types::Duration { | ||
| seconds: p.as_secs() as i64, | ||
| nanos: 0, | ||
| }), | ||
| period_spend_limit: convert_coins(self.period_spend_limit.clone()), | ||
| period_can_spend: convert_coins(self.period_can_spend.clone()), | ||
| period_reset: self.period_reset.map(convert_stamp), | ||
| } | ||
| .encode_to_vec(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl FeeGranterAllowance for AllowedMsgAllowance { | ||
| fn to_any(&self) -> Any { | ||
| Any { | ||
| type_url: feegrant::v1beta1::AllowedMsgAllowance::TYPE_URL.to_string(), | ||
| value: feegrant::v1beta1::AllowedMsgAllowance { | ||
| allowance: self.allowance.as_ref().map(|a| a.to_any()), | ||
| allowed_messages: self.allowed_messages.clone(), | ||
| } | ||
| .encode_to_vec(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We should probably use Into<Any>
There was a problem hiding this comment.
Unfortunately it's used in dyn trait object and Into is marked with Sized, which makes it not object-safe
Is it just test-tube or Osmosis as a chain? |
CyberHoward
reviewed
Nov 14, 2023
| base: &'a T, | ||
| deps: cosmwasm_std::Deps<'a>, | ||
| // We use a RefCell here to allow for the granter to be set after the FeeGranter is created | ||
| granter: RefCell<Option<Addr>>, |
There was a problem hiding this comment.
This should just be owned type. The struct can be mut if the user wants to set the granter.
I.e. change fn granter(&self, ...) to fn granter(&mut self, ...)
CyberHoward
deleted the
adair/abs-56-rename-grant-feature-to-fee_grant-and-feegrant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the fee-grant API to be usable. The previous version of the API encoded every single one of the messages improperly and was almost unusable.
It also creates a proof-of-concept abstract app for managing fee grants from an account. It is called "gas-station" and allows the Account to create grades of gas for different selections of gas tokens on the network, as well as different default expirations (TODO). Then, they can activate a gas pass for a user / contract, which will fee grant from the proxy on the account.
Check out the readme for it as to why it's better.
NOTE:
Checklist