Incorporating Phil's changes to get SSL working again. #1
Conversation
This commit represents a (slightly modified) version of commits from e3adcd0ff45ed029ffd7d68a2152e587e3b46a89 at https://github.com/philip-doctor/cassaforte. The only change from those commits is that the project owner here is absurdfarce... pretty sure that's necessary to keep clojars happy.
|
@philip-doctor I think I got everything from your branch... please double-check me and make sure I didn't miss anything. |
| (-> (JdkSSLOptions/builder) | ||
| (.withSSLContext ssl-context) | ||
| (.withCipherSuites ssl-cipher-suites)))) | ||
| (.. (JdkSSLOptions$Builder.) |
There was a problem hiding this comment.
So I get (and prefer) the .. syntax here... but why the change to instantiating a Builder class directly? JdkSSLOptions/builder does the same thing, doesn't it?
There was a problem hiding this comment.
I'm fine with going back to (JdkSSLOptions/builder) it's probably a better choice in case DS java team starts adding logic to that method anyhow, so +1, the change I was debugging here is that we needed to (build) as a part of this and we were missing that step.
There was a problem hiding this comment.
Yeah, the missing build() call was... horrible. I have no idea how I missed that one... thanks for catching it!
There was a problem hiding this comment.
no problem, I'm here to try to fix a bug, not pass judgement, don't worry about it :)
|
@philip-doctor Apologies, the day got away from me a bit today. I think I covered everything we wanted to change here... can you take one more pass and make sure you're happy with what's here? If you are then I'll push up a new JAR containing these changes. |
Incorporating Phil's changes to get SSL working again.
This commit represents a (slightly modified) version of commits from e3adcd0ff45ed029ffd7d68a2152e587e3b46a89
at https://github.com/philip-doctor/cassaforte. The only change from those commits is that the project owner
here is absurdfarce... pretty sure that's necessary to keep clojars happy.