max and min return shaped arrays

util/axisOps.js

@@ -14,7 +14,7 @@ module.exports = (shape, axis) => {
         jumpLen *= shape[i];
     }
     jumpLen /= shape[axis];
-    for (let i = 0; i < (size - jumpLen); i++) {
+    for (let i = 0; i <= (size - jumpLen); i++) {
         let inElems = [];
         inElems.push(i);
         for (let k = 1; k < shape[axis]; k++) {

util/max.js

@@ -14,23 +14,22 @@
 module.exports = function max({ ar1, ar2 = null, axis = 0 }) {
     const axisOps = require('./axisOps'),
         { flatten, arrange, calc_shape, calc_size } = require('../lib/core');
-    let maxElems = [];
+    let maxElems = [],
+        opShape = [];
     if (!ar2) {
         let shape = calc_shape(ar1),
             elems = axisOps(shape, axis);
         ar1 = flatten(ar1);
         for (let i = 0; i < elems.length; i++) {
             let max = ar1[elems[i][0]];
             for (let j = 0; j < elems[i].length; j++) {
-                console.log(ar1[elems[i][j]]);
-                if (ar1[elems[i][j]] > max) {
-                    max = ar1[elems[i][j]];
-                    console.log('max is now :', max);
-                }
+                max = Math.max(ar1[elems[i][j]], max);
             }
             maxElems.push(max);
         }
+        opShape = [];
     } else {
+        opShape = calc_shape(ar2);
         if (!Array.isArray(ar1) && Array.isArray(ar2)) {
             ar2 = flatten(ar2);
             maxElems = ar2.map(i => Math.max(ar1, i));
@@ -47,5 +46,5 @@ module.exports = function max({ ar1, ar2 = null, axis = 0 }) {
             }
         }
     }
-    return maxElems;
+    return arrange(opShape, maxElems);
 }

util/product.js

@@ -16,7 +16,6 @@ module.exports =
                 s2 = calc_shape(arr2);
             if (s1.length === 2 && s2.length === 2) {
                 if (s1[1] === s2[0] && mode === 'matrix') {
-                    console.log('producting matrix');
                     return arrange([s1[0], s2[1]], matmul(s1, s2, t1, t2, ));
                 } else if (mode === 'dot') {
                     if (s1.toString() === s2.toString()) {