New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Error/Extrapolation bug #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Updated test class docstring and removed commented out code.
aburrell
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I verified that the unit tests fail as expected with the older version of the code. I fixed up some style issues in the new unit tests and made a suggestion for cleaning up the style of the code. I agree that the current failure is out of scope for this pull.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
aburrell
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR to make it easier to track some of the issues/changes pertinent to #115. The main problem was a variety of memory errors that seemed to occur somewhat randomly when an
Apex
object was initialized, but there seem to be several things that potentially could contribute to this. (See #115 for ongoing discussion - will copy main points to this thread when ready to review).Note: This PR should replace #116
Fixes #115 (not yet)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration
Checklist
develop
(notmain
) branchChangelog.rst
, summarising the changesAUTHORS.rst
and.zenodo.json