Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Error/Extrapolation bug #117

Merged
merged 13 commits into from Mar 28, 2023
Merged

Conversation

ljlamarche
Copy link
Collaborator

@ljlamarche ljlamarche commented Mar 23, 2023

Description

This is a draft PR to make it easier to track some of the issues/changes pertinent to #115. The main problem was a variety of memory errors that seemed to occur somewhat randomly when an Apex object was initialized, but there seem to be several things that potentially could contribute to this. (See #115 for ongoing discussion - will copy main points to this thread when ready to review).

Note: This PR should replace #116

Fixes #115 (not yet)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Confirm that short example scripts can be run.
  • Check that the fortran test program compiles and generates the correct output.
  • Standard unit tests

Test Configuration

  • Operating system: MacOS 12.6.1 M1
  • Python version number: 3.10.9
  • Compiler with version number: gfortran 12.2.0

Checklist

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

@ljlamarche ljlamarche mentioned this pull request Mar 24, 2023
@ljlamarche
Copy link
Collaborator Author

Of the tests that are sill failing, one I believe will be fixed by 5f0fdf8 and ed033f2, and the other two are related to #113, which is a separate and relatively isolated issue.

@ljlamarche ljlamarche marked this pull request as ready for review March 27, 2023 19:46
ljlamarche and others added 2 commits March 27, 2023 12:47
Updated test class docstring and removed commented out code.
Copy link
Owner

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I verified that the unit tests fail as expected with the older version of the code. I fixed up some style issues in the new unit tests and made a suggestion for cleaning up the style of the code. I agree that the current failure is out of scope for this pull.

fortranapex/igrf.f90 Outdated Show resolved Hide resolved
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@aburrell aburrell merged commit 01b28a8 into aburrell:develop Mar 28, 2023
12 of 14 checks passed
@ljlamarche ljlamarche deleted the extrapolation_bug branch March 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants