Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMPERE update #125

Merged
merged 10 commits into from Mar 15, 2023
Merged

AMPERE update #125

merged 10 commits into from Mar 15, 2023

Conversation

aburrell
Copy link
Owner

@aburrell aburrell commented Mar 14, 2023

Description

Adds new AMPERE boundaries. These have an extended time range, use the re-processed AMPERE data, and include the Heppner-Maynard Boundary as a potential equatorward boundary for gridding purposes.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

import ocbpy
import datetime as dt

stime = dt.datetime(2021, 1, 1)
dual = ocbpy.DualBoundary(stime=stime, hemisphere=-1)

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant: N/A

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My commits are formatted appropriately (following the SciPy/NumPy style)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

Added AMPERE OCBs from the updated data set.  Now spans 2010-2021 (inclusive).
Added AMPERE EABs from the updated data set, using the HMB as an EAB proxy.  Spans 2010-2021 (inclusive).
Updated the boundary files' README to reflect the new AMPERE boundary data.
Updated the new AMPERE file end time.
Updated the boundary classes to include AMPERE as a valid EAB option.
Update the AMPERE boundary descriptions and references.
Update the changelog with a description of the two boundaries added.
@aburrell aburrell added this to the 0.4.0 milestone Mar 14, 2023
Wiley links appear as broken in doc tests.  Replaced the DOI links with simple DOIs.
Updated the file tests to include the updated AMPERE date ranges and files.
Update the IMAGE citations to be correct and not include active links to Wiley.
@coveralls
Copy link

Coverage Status

Coverage: 99.089%. Remained the same when pulling c522df0 on ampere_update into 1885343 on develop.

@coveralls
Copy link

Coverage Status

Coverage: 99.089%. Remained the same when pulling bbe4cae on ampere_update into 1885343 on develop.

@aburrell aburrell merged commit 1046849 into develop Mar 15, 2023
68 checks passed
@aburrell aburrell deleted the ampere_update branch March 15, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants