Add geographic coordinate options #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created separate functions to convert vectors from one coordinate system to another.
Adapted VectorData to: - accept geodetic or geocentric coordinates as vector inputs, - use the new vector functions in the methods, and - simplify the print output to be more streamlined.
Updated the OCB scaling unit tests by: - updating the error messages raised, - removing tests for updated quad lists from scaling vectors as this functionality is no longer present, and - updated the minimum amount of attribute names to reflect changes in the VectorData class.
Added a description of the vector changes to the changelog.
Added range fixing to all time conversion functions.
Updated the time unit tests for range fixing.
Updated the description of the `get_pole_loc` function.
Created a test suite for the vector functions.
Ensure latitudes are array-like and that flat/zero masking is correct for array-like input when calculating the pole-data-pole angle.
Added unit tests for the `calc_vec_pole_angle` function.
Fixed the quadrant assignment in the `test_calc_vec_pole_angle_flat` integration test. Also updated docstrings to be more correct.
Added the new bug that is fixed to the changelog.
Improved the robustness of the destination pole quadrant identification by: - setting the size after finding the time difference instead of assuming it will always be equal to the pole angle, - testing the cycle condition for floats as well as arrays, and - testing the cycle condition for large angles as well as negative angles.
Added unit tests for `define_pole_quadrants` and simplified unit tests by making some of the variables class variables.
Added unit tests for the vector quadrant determination.
Improved `calc_dest_polar_angle` by ensuring list inputs can be used.
Added unit tests for the vector function `calc_dest_polar_angle`.
Improved array/float handling in the `adjust_vector` and `calc_dest_polar_angle` functions.
Removed extra whitespace.
Improved test class setup/teardown and added unit tests for the `adjust_vector` function.
Added access to deprecated attributes as properties or normal attributes (based on their previous type).
Updated a warning message to make more sense.
Added unit tests for the deprecation warnings in the VectorData class.
Remove a doubly-defined test and improve the comments.
Fix the degree handling in `hr2deg` to be consistent with other longitude range handling.
Added logging test for the new time logger warning.
Added an attribute deprecation warning for `aacgm_naz`.
Added a test for the `aacgm_naz` deprecation warning.
Scale the OCB vector components, not the original vector components.
Update the VectorData call in SuperMAG to reduce deprecation warnings.
Rename test files to better conform to real file names.
Update test filenames to conform with name change.
Allow geographic coordinates to be used by pysat Instruments.
Update pysat tests by: - adding a base class for the pysat methods tests, - setting boundary classes by input kwargs, - updating structures for new inputs, and - using new test file names.
Improve the error message output to be more informative.
Updated the supported Python versions to reflect current NEP 29.
Added the Python cycling to the changelog.
This was
linked to
issues
May 6, 2024
Remove failing tests that rely on deprecated code.
Use time conversion function to determine the desired range and improved the handling of mixed inputs to `calc_dest_polar_angle`.
Added tests to access lines uncovered in the vector subroutines.
Remove the support for Python versions less than 3.9.
Fixed bugs in `update_loc_coords` and elsewhere by: - updated unused kwarg warning to work with or without deprecated kwargs, - added specification of trace method in all applicable methods, - fixed typo that assigned local time data to latitude, and - fixed unnecessary usage of array function.
Added vector data tests to: - test the uncovered logging messages, - test the uncovered error messages, and - test `update_loc_coords`.
Fixed missing output and missing use of `trace_method` in `update_vect_coords_to_mag`.
Added unit tests for `update_vect_coords_to_mag`.
Remove extra whitespace from a blank line.
Added coverage for two remaining uncovered lines.
Fixed the `add_ocb_to_data` function in `pysat_instruments` by: - adding error catch for badly shaped array-like height input for pandas instruments, - removing an unreachable section of code to add time to LT data, - adding an evaluation to avoid unnecessary calls to meshgrid, and - adding an extra meshgrid call for reshaping with height to reduce memory use.
Added tests for `pysat_instruments` to cover missed lines.
Improved the robustness of the padding function to catch more potential errors.
Added unit tests for `reshape_pad_mask_flatten`.
|
Change in coverage is consistent with fixes made to SSJ code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #127 and #132 by allowing geographic coordinates to be used in VectorData and the pysat Instrument functions. Also updated the pysat example.
Type of change
Please delete options that are not relevant.
to not work as expected)
How Has This Been Tested?
Wrote new unit tests, ran new example.
Test Configuration
Checklist:
develop(notmain) branchChangelog.rst, summarising the changesAUTHORS.rstand.zenodo.json