This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
Fixed rotation issue on iPhone 6 Plus #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue in landscape on iPhone 6 where the frame is incorrect.
|
Hey Mate. Can't merge this due to an issue with the CI: 2014-11-01 10:07:09.292 xctool[1184:2907] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[SimDeviceSet defaultSet]: unrecognized selector sent to class 0x100b8f280' If this gets fixed I'll be happy to merge. |
|
When is that called? Doesn't make sense!:P I only added like 9 lines that flips the bounds so its always portrait bounds. |
|
Just googled the SimDeviceSet and found this? facebookarchive/xctool#380 I have no idea what xctool is |
|
Wow, I let this go for a long time. Really sorry mate. I'm going to merge this and do a release in the next few days. |
abury
added a commit
that referenced
this pull request
Apr 16, 2015
Fixed rotation issue on iPhone 6 Plus
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in landscape on iPhone 6 where the frame is incorrect.