Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Handlebars support #38

Closed
wants to merge 1 commit into from
Closed

Add Handlebars support #38

wants to merge 1 commit into from

Conversation

danielbankhead
Copy link

Adding "*.hbs": "html"/"*.handlebars": "html" to "files.associations" breaks compatibility with existing Handlebars extensions. Since Handlebars can be used as a superset of HTML this change should not be a problem.

Adding `"*.hbs": "html"`/`"*.handlebars": "html"` to "files.associations" breaks compatibility with existing Handlebars extensions. Since Handlebars can be used as a superset of HTML this change should not be a problem.
@abusaidm
Copy link
Owner

hello @danielbankhead ,
Are you saying adding this extension will cause Handlebars extensions to break?
Can you elaborate please.

Thank you.

@danielbankhead
Copy link
Author

Hey @abusaidm,

I was able to solve my issue. I was updating files.associations in my settings.json per the FAQ instructions found on the Marketplace README, which didn't help since changing the Handlebars extension (*.hbs) from 'handlebars' to 'html' broke compatibility with existing packages that expect 'language' === 'handlebars', such as andrejunges.Handlebars.

However, the updated README on this repo links to a helpful comment that solved my issue. Perhaps an update on the Marketplace README to avoid confusion?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants