Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$Data::Dumper::vars are changed globally. [rt.cpan.org #117880] #136

Closed
atoomic opened this issue Oct 5, 2018 · 1 comment · Fixed by #286
Closed

$Data::Dumper::vars are changed globally. [rt.cpan.org #117880] #136

atoomic opened this issue Oct 5, 2018 · 1 comment · Fixed by #286
Labels
Feature Request

Comments

@atoomic
Copy link
Collaborator

atoomic commented Oct 5, 2018

Migrated from rt.cpan.org#117880 (status was 'new')

Requestors:

From pause@datademons.com on 2016-09-16 01:38:37:

When Data::Dumper is instantiated by this module, it changes the values of
$Data::Dumper variables globally.  This leaves them in an inconsistent state
for other modules throughout the application that uses it.

A better use would be to either use Data::Dumper as an object, or at least
local()ise any changes to its variables for the duration of its run.
@toddr
Copy link
Collaborator

toddr commented Oct 5, 2018

This seems easily done. needs a patch

dnfm added a commit to dnfm/Template2 that referenced this issue Apr 27, 2021
@dnfm
Use Data::Dumper as an object.
fd38ada 
Instead of just setting global Dumper variables, use it as an object so
it doesn't affect any calling code.

Fixes abw#136
@dnfm dnfm mentioned this issue Apr 27, 2021
Merged
@abw abw closed this as completed in #286 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 136 dnfm/Template2
2 participants
@toddr @atoomic