Remove indenting within compiled templates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a template contains a multiline string, within for example a call to
a Locale::gettext template function for translation, then the compiled
version of the string written to the compiled template file will contain
extra indent whitespace due to the regular expressions within the
as_perl() function. For example, the template fragment:
[% loc("This is a
multiline string.") %]
will be written to the compiled file as something like
$output .= $stash->get(['loc', [ 'This is a
multiline string.' ]]);
This means that - once a compiled template is loaded in, after say a
server restart - the translation stops working because the original
string does not exactly match the translation string.
The indentation appears to be optional, and is only within compiled
template files, so this commit simply removes it.
abw
added a commit
that referenced
this pull request
Jan 8, 2014
Remove indenting within compiled templates
djzort
pushed a commit
to openlocal/fixmystreet
that referenced
this pull request
Apr 3, 2014
Embed a local copy of Template::Document, which includes the change of abw/Template2#29 so that multiline quoted strings within a template are not indented and thus stop translating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a template contains a multiline string, within for example a call to a Locale::gettext template function for translation, then the compiled version of the string written to the compiled template file will contain extra indent whitespace due to the regular expressions within the as_perl() function. For example, the template fragment:
will be written to the compiled file as something like (note indentation):
This means that - once a compiled template is loaded in, after say a server restart - the translation stops working because the original string does not exactly match the translation string.
The indentation appears to be optional, and is only within compiled template files, so this commit simply removes it.