Return empty string from list import. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation never said that a list was returned; indeed the example provided is broken in that it prints out ARRAY(...) if run. Let us change its behaviour to do as expected by the docs.
This was referenced Jan 2, 2018
Closed
|
We actually found production code that broke over this. I am reverting it via e75f303. More details to follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation never said that a list was returned; indeed the example provided is broken in that it prints out ARRAY(...) if run. Let us change its behaviour to do as expected by the docs.
Either this or #73 will fix #33, but not both :)