This repository has been archived by the owner on Feb 9, 2019. It is now read-only.
Database Abstraction #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't get too far behind
further refactoring to make that possible. Moved interface NxtKey from .db.sql to .db
further refactoring to make that possible.
Disabled the scan method for the moment - its complicated to update and we are not sure if it works like it should Unfortunately the whitespace in this file was different from the other files and i noticed too late i changed most of it. Please add "?w=1" to the diff view to just see code changes (and some minor brace reformats)
This reverts commit f126061.
Disabled the scan method for the moment - its complicated to update and we are not sure if it works like it should Reworked BlockchainProcessorImpl-Changes since githubs diff view sucks when encountering simple whitespace changes
Re-Added accidentally deleted FilteringIterator
There might be some lingering race conditions in there!
…package private mariadb implementations
…ver again when far behind
…ver again when far behind (fix for false blacklisting)
ac0v
added a commit
that referenced
this pull request
Sep 7, 2017
ac0v
added a commit
that referenced
this pull request
Feb 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a truly huge update that separates database access from business-logic.
Since until now database access was embedded in almost every class i had to touch almost every class.
All access is now via interfaces. Currently there is only a mysql implementation. The next step is to get h2 back into the application.This version supports both h2 and mariadb. Just adjust the databases jdbc: - url to choose the one you want.
Interfaces are in nxt.db. A generic sql implementation is in nxt.db.sql, mariadb implementation is in nxt.db.sql.mariadb and h2 in nxt.db.sql.h2
Currently the mariadb implementation is mostly empty - this will change when h2 is integrated (making methods in nxt.db.sql abstract and adding specific implementations to mariadb/h2).THIS IS UNTESTED AT THE MOMENT - THIS PULL-REQUEST IS MAINLY FOR REVIEW
Shameless plug: Feel free to throw some burst to BURST-BJSX-4C6A-UH35-F4Q3A if you like this change ;)