Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what gets hashed #2

Closed
judgej opened this issue May 9, 2017 · 2 comments
Closed

Determine what gets hashed #2

judgej opened this issue May 9, 2017 · 2 comments

Comments

@judgej
Copy link
Member

judgej commented May 9, 2017

It seems that the merchant site chooses what fields are included in the data hash when POSTing to the remote payment page. There could be instances where everything has to remain unchanged, so all fields are hashed. There could also be times where some details (e.g. billing address) are left open so they can be edited before going to the offsite payment form. I could even imagine the amount being left unhashed if an arbitrary donation is being paid.

So, how do we indicate what gets hased and what is not hashed? Group fields perhaps - addresses, names, amount - and have flags for ewach of these? Assume everything is hashed unless a hash is disabled for fields or groups? Any other approach?

@judgej
Copy link
Member Author

judgej commented May 9, 2017

Propbably, for now, just assume the POST to the gateway payment page will be automated, so nothing should be changed by a user. Any user-entered changes happen before getting to the auto-post.

@judgej
Copy link
Member Author

judgej commented May 15, 2017

We are hashing everything generated by the gateway. The merchant site can add further fields outside of the driver, so long as those fields only optionally appear in the fingerprint.

@judgej judgej closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant