Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-ui-react 2.0.3? #55

Closed
yurikhan opened this issue Mar 19, 2021 · 6 comments · Fixed by #61
Closed

semantic-ui-react 2.0.3? #55

yurikhan opened this issue Mar 19, 2021 · 6 comments · Fixed by #61
Assignees

Comments

@yurikhan
Copy link

Hello, is this library being maintained? The current version of semantic-ui-react is 2.0.3 but react-semantic-toasts declares a peer dependency compatible with up to 0.88.

@ferrao
Copy link
Member

ferrao commented Mar 19, 2021

Hi @yurikhan we do not use it internally anymore and that is why its dependencies are outdated, but feel free to submit a PR and I will merge.

@ferrao ferrao self-assigned this Mar 19, 2021
@Zerquix18
Copy link
Contributor

Hello @ferrao are you still open to this? I'm looking forward to updating my semantic-ui-react version but it doesn't allow me because of the peer dependencies of this one.

@Zerquix18
Copy link
Contributor

Also, it seems to lock me on React 16.x.x. Any chance it may work on React 17? Or should I test?

@ferrao
Copy link
Member

ferrao commented Sep 7, 2021

Hi @Zerquix18, totally opened to merge a PR, please go ahead!

@Zerquix18
Copy link
Contributor

Just had a look at it and it looks like semantic-ui-react is used?:

https://github.com/academia-de-codigo/react-semantic-toasts/blob/master/lib/semantic-toast.jsx#L3
https://github.com/academia-de-codigo/react-semantic-toasts/blob/master/lib/with-transition.jsx#L2

The use seems very simple. I guess it would be fine to allow any version?

I tried running npm run build using React "16.x.x || 17.x.x" and semantic ui react "*" as peer dependencies and it seemed to work.

@ferrao
Copy link
Member

ferrao commented Sep 16, 2021

I tried running npm run build using React "16.x.x || 17.x.x" and semantic ui react "*" as peer dependencies and it seemed to work.

Just open a PR with the updated dependencies and I will merge it @Zerquix18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants