Add onDismiss function option when a toast is created #39
Conversation
lib/semantic-toast.jsx
Outdated
| @@ -16,6 +16,7 @@ function SemanticToast(props) { | |||
|
|
|||
| const onDismiss = e => { | |||
| e.stopPropagation(); | |||
| props.onDismiss(); | |||
There was a problem hiding this comment.
Can you please destructure onDismiss as well?
|
Don't understand the title of this PR, does not seem related to your description/code. Can you please clarify? |
doncicuto
changed the title
As requested, I've destructure onDismiss. I've chosen onDispel as a synonym for onDismiss inside semantic-toast.jsx to avoid repetition.
|
@ferrao @doncicuto This change is not applied to npmjs, or is it just me? I tried This is causing an error I can easily solve this by changing my package.json into Can you help me with this, maybe I do something wrong. I've tried:
|
|
Hi @michael-harley,
I've only set size to small as it complained about medium size not defined in current React Semantic version which has already been tackled in @jankaifer PRs. I'm not sure what may be the cause for your issue but if I can help you let me know. Cheers |
This component is quite useful, thanks a lot!
In my case, I wanted to perform some actions that should only be triggered once the toast was explicitely dismissed by clicking the close sign, so I've added the onDismiss support. onClose it is called either you click on the close sign or if the time passes and the toast is closed. With the onDismiss function, if you want to do specific things when the X is clicked, you now can do your stuff before the toast is closed.