Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve docs #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Improve docs #2

wants to merge 4 commits into from

Conversation

nate00
Copy link
Member

@nate00 nate00 commented May 12, 2016

  • Method docs
  • Class docs
  • Implementation details
  • Complete examples

# [+#{attribute_name}_key+]
# The key in Memcached that stores the count.
# [+#{attribute_name}_count=(value)+]
# Sets the value of the count.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it might be worth adding parenthetically here that you don't need to call this except for testing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was actually just about to remove mention of this method. Similarly, I wasn't going to document {increment,decrement}_*_count. Do you think there's value in mentioning any of those?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might, in fact, want to use them in testing, so mentioning somewhere seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants