Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stats for student ages #323

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

rono516
Copy link
Contributor

@rono516 rono516 commented Nov 11, 2023

This pull request adds statistics for student ages from ranges added in the config file

Screenshot (332)

As seen above the number of students in various ages is displayed in the bar graph

Screenshot (333)

The stats are also displayed in a table format to show all values which are not visible in the bar graph

@thdebay
Copy link
Collaborator

thdebay commented Nov 12, 2023

Thanks a lot @rono516 for this PR. It is looking really good. I will merge it as it is, since I've been able to test it and everything works. Since you asked for feedback, there are a couple of improvements I can think about (feel free to submit another PR if you want to add these points):

  • it would be nice to have some unit tests to ensure the feature is working as it should and that the numbers are consistent with the data in the database

  • from a business logic perspective, the graphs you created are based on the students from the students table (ie. all users registered in the system); it would also be interesting to have the ability to display the same graph per period. In that case, we would need to look at the enrollments table (in a similar way to what is done for the gender report). It would allow to get more details about the age distribution.

But the work you've done is already highly appreciated, thanks again!

@thdebay thdebay merged commit 6067d35 into academico-sis:oss Nov 12, 2023
1 check failed
@rono516
Copy link
Contributor Author

rono516 commented Nov 12, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants