Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of angle for F82 #87

Closed
natyh opened this issue Aug 25, 2023 · 3 comments
Closed

Definition of angle for F82 #87

natyh opened this issue Aug 25, 2023 · 3 comments

Comments

@natyh
Copy link

natyh commented Aug 25, 2023

The specification says (in the comments on equation (43), that the angle for F82 is defined as 82 degrees. This is not accurate - the actual angle should be defined as arccos(1/7), which is close to but not exactly 82 degrees. In other words, mu_bar is defined as exactly 1/7. This is needed for the math to work out with integer powers, etc.

@portsmouth
Copy link
Contributor

Thanks Naty, I will make a PR to fix up that mistake.

@portsmouth
Copy link
Contributor

See #90

@jstone-lucasfilm
Copy link
Member

Thanks for the fix, @portsmouth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants