Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in export of Householder QR based lin. solver #46

Closed
mvukov opened this issue Aug 12, 2013 · 2 comments
Closed

Bug in export of Householder QR based lin. solver #46

mvukov opened this issue Aug 12, 2013 · 2 comments
Assignees
Labels
Milestone

Comments

@mvukov
Copy link
Member

mvukov commented Aug 12, 2013

While extending the QR based lin. solver I think I found a bug. @rienq please take a look at commit mvukov@d0219e4. I commented out some lines and fixed the loop limit of the outer-most loop of the factorization routine.

The basic problem was that the last element of the R matrix, i.e. R(nc, nc), was wrong.

The solver works now w/o reuse feature. I compared results (for both cases m=n, m > n) against MATLAB and everything is fine.

@rienq please fix the solver so that it works with reuse of factorization again. Thanx! :)

@ghost ghost assigned rienq Aug 12, 2013
@mvukov
Copy link
Member Author

mvukov commented Aug 26, 2013

Hello @rienq ? Any progress on this so far? :)

@rienq
Copy link
Member

rienq commented Aug 26, 2013

sorry, no.. will try to have a look at it later this week !

rienq added a commit to rienq/acado that referenced this issue Aug 31, 2013
@rienq rienq closed this as completed Aug 31, 2013
mvukov added a commit to mvukov/acado that referenced this issue Oct 7, 2013
- In the Householder QP decomposition, since acado#46 is solved
- In the ExportAcadoFunction, because it is giving me more headache
  than helping me debug the code. There is a comment and todo there now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants