New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATLAB interface for Manual external cost in C #634
MATLAB interface for Manual external cost in C #634
Conversation
13ea662
to
399c6a9
Compare
Hey @FreyJo |
45744ff
to
c6d5682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mindThomas ,
I had a closer look.
Thanks for the bug fixes!
I would suggest you merge these changes mindThomas#3
then maybe @giaf has another look, and we merge this PR here.
Ah, I realized you @mindThomas allowed me to push on your branch, so I just did. |
@FreyJo Yup. Since you are a maintainer of the upstream repository this permission is easily and if I am not mistaken by default granted when creating the pull request: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork Thanks for the code formatting cleanup and the missed template. |
Great! I just wasn't aware this is possible by default. |
Updated MATLAB interface to add support for custom external C files for the cost.
Cost function names are source files are manually specified and compiled and linked during the solver compilation step.