Fix rails#5238, rendered_format is not set when template is not rendered

acapilleri · Mar 2, 2012 · 1a71e84 · 1a71e84
1 parent bbe7dac
commit 1a71e84
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/actionpack/lib/action_view/renderer/partial_renderer.rb b/actionpack/lib/action_view/renderer/partial_renderer.rb
@@ -273,6 +273,8 @@ def setup(context, options, block)
       @block   = block
       @details = extract_details(options)
 
+      @lookup_context.rendered_format ||= formats.first
+
       if String === partial
         @object     = options[:object]
         @path       = partial

diff --git a/actionpack/test/controller/render_test.rb b/actionpack/test/controller/render_test.rb
@@ -1241,22 +1241,26 @@ def test_using_layout_around_block_in_main_layout_and_within_content_for_layout
   def test_partial_only
     get :partial_only
     assert_equal "only partial", @response.body
+    assert_equal "text/html", @response.content_type
   end
 
   def test_should_render_html_formatted_partial
     get :partial
-    assert_equal 'partial html', @response.body
+    assert_equal "partial html", @response.body
+    assert_equal "text/html", @response.content_type
   end
 
   def test_should_render_html_partial_with_formats
     get :partial_formats_html
-    assert_equal 'partial html', @response.body
+    assert_equal "partial html", @response.body
+    assert_equal "text/html", @response.content_type
   end
 
   def test_render_to_string_partial
     get :render_to_string_with_partial
     assert_equal "only partial", assigns(:partial_only)
     assert_equal "Hello: david", assigns(:partial_with_locals)
+    assert_equal "text/html", @response.content_type
   end
 
   def test_partial_with_counter