Ensure -lm specified, and other tidying up of CFLAGS, CPPFLAGS, LDLIBS and LDFLAGS #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure was testing whether it was necessary to add the -lm option, but for some reason gcc adds it itself if -Os is not specified, but does not add it if -Os is specified. Consequently if configure was run without -Os, and make was run with -Os the link failed. The commit ensures that -lm is always used. Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
… files Make sure any settings in CFLAGS etc at the time configure is run are added to the Makefiles, to ensure that the make is run in the same environement that configure is run in. Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
Use the correct variable for the relevant option type, e.g. -llib should be in LDLIBS, not LDFLAGS, and -Ddefn should be in CPPFLAGS not CFLAGS. Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
vincentbernat
added a commit
to vincentbernat/keepalived
that referenced
this pull request
Jun 6, 2020
First, this reverts changes made in acassen#416 (commit 328ec28). With lldpd, I don't use `--netsnmp-agent-libs --external-libs` and I never had an issue with Ubuntu 14.04. From my understanding, the code to fix mangle `NETSNMP_LIBS` to fix issues with Fedora is then not needed anymore because the issue appears only because of `--external-libs`, so the code can be removed as well. This was added in acassen#858 (commit 057c279). Then, this also reverts changes introduced in acassen#1262, notably commit 63fe1f4. Seperating CPPFLAGS from CFLAGS also reorder some flags, making headers in `/usr/lib/*/perl/*/CORE` used before the ones in `lib/`. This happens for `parser.h` and leads to this error when NetSNMP is linked to libperl. This happens with out-of-tree builds when `-I$(srcdir)/../include -I$(srcdir)/../../lib` is appended too late. ``` In file included from ../../../keepalived/core/main.c:54: /usr/lib/x86_64-linux-gnu/perl/5.30/CORE/parser.h:15:5: error: unknown type name ‘YYSTYPE’ 15 | YYSTYPE val; /* semantic value */ | ^~~~~~~ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.