fix buffer overflow when receive radius packet #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlobanov
force-pushed
the
fix-radius-overflow
branch
from
7b2a3a3
to
6e2b048
Compare
|
Thanks @svlobanov , could you add one more credit: Reported-by: Chloe Ong The patched code looks fine. Thank you! |
|
Apologies @svlobanov, we spotted one more issue, the size has not been specified for the |
svlobanov
force-pushed
the
fix-radius-overflow
branch
from
6e2b048
to
a842603
Compare
|
@spaceraccoon thank you, the patch has been updated |
This patch fixes buffer overflow if radius packet contains invalid atribute length and attrubute type from the following list: ipv4addr, ipv6addr, ipv6prefix or ifid Reported-by: Chloe Ong Reported-by: Eugene Lim <spaceraccoon@users.noreply.github.com> Reported-by: Kar Wei Loh Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
svlobanov
force-pushed
the
fix-radius-overflow
branch
from
a842603
to
d4cb897
Compare
|
Hi @svlobanov , looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes buffer overflow if radius packet contains invalid atribute length
and attrubute type from the following list: ipv4addr, ipv6addr or ifid
Reported-by: Chloe Ong
Reported-by: Eugene Lim spaceraccoon@users.noreply.github.com
Signed-off-by: Sergey V. Lobanov sergey@lobanov.in