Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant rows generation #294

Merged
merged 20 commits into from Mar 26, 2021
Merged

Relevant rows generation #294

merged 20 commits into from Mar 26, 2021

Conversation

zaibacu
Copy link
Contributor

@zaibacu zaibacu commented Mar 4, 2021

  • Allow to generate by concrete data instead of row number
  • Initial barebones for UI integration testing. Process is there, but lacking actual tests

@zaibacu zaibacu requested a review from rokasramas March 4, 2021 16:08
@zaibacu
Copy link
Contributor Author

zaibacu commented Mar 5, 2021

Initial row seems to be ignored, working on it

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #294 (75afdbc) into master (b47451c) will increase coverage by 4.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   68.29%   72.92%   +4.63%     
==========================================
  Files          88       90       +2     
  Lines        3441     4137     +696     
  Branches      189      195       +6     
==========================================
+ Hits         2350     3017     +667     
- Misses        902      925      +23     
- Partials      189      195       +6     
Flag Coverage Δ
api 66.53% <ø> (+0.27%) ⬆️
core 79.53% <ø> (+8.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/acc_text/nlg/gf/paths.clj 81.81% <0.00%> (-18.19%) ⬇️
core/src/acc_text/nlg/graph/categories.clj 86.36% <0.00%> (-8.64%) ⬇️
core/src/acc_text/nlg/core.clj 96.15% <0.00%> (-3.85%) ⬇️
api/src/data/entities/document_plan/utils.clj 82.35% <0.00%> (-2.03%) ⬇️
api/src/api/config.clj 17.64% <0.00%> (-1.11%) ⬇️
api/src/api/graphql/translate/dictionary.clj 86.00% <0.00%> (-0.67%) ⬇️
core/src/acc_text/nlg/graph/utils.clj 94.93% <0.00%> (-0.66%) ⬇️
core/src/acc_text/nlg/graph/data.clj 92.59% <0.00%> (-0.52%) ⬇️
core/src/acc_text/nlg/dictionary/item.clj 81.81% <0.00%> (ø)
api/src/api/graphql/translate/document_plan.clj 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47451c...75afdbc. Read the comment docs.

@rokasramas
Copy link
Member

Screenshot from 2021-03-05 16-22-18
Something is not right, to reproduce this, upload two files, switch rows, select another file. In this case, files have similarly named columns, and as you see generation is using data from another file.
It would also be nice if "First 20" was first selection by display order, and keep it selected by default.

Copy link
Member

@rokasramas rokasramas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working ok now, just last thing - "First 20" should come before "Most relevant":
Screenshot from 2021-03-25 10-41-18

@rokasramas rokasramas self-requested a review March 25, 2021 14:57
Copy link
Member

@rokasramas rokasramas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating new document plan selection "First 20" switches to "Most relevant"

@rokasramas rokasramas merged commit 4ff99e3 into master Mar 26, 2021
@rokasramas rokasramas deleted the relevant-rows-generation branch March 26, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants