Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend dictionary item schema #302

Merged
merged 9 commits into from
Mar 18, 2021
Merged

Conversation

rokasramas
Copy link
Member

@rokasramas rokasramas commented Mar 16, 2021

Additionally improved:

  • AMR argument handling when categories are ambiguous (there will be no more errors when inside AMR the same argument has NP, CN and N categories, as well as others that are compatible)
  • Document plan "about" text in UI can be added via graphql

@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #302 (9186327) into master (a322f9b) will increase coverage by 0.07%.
The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   72.94%   73.01%   +0.07%     
==========================================
  Files          89       89              
  Lines        4077     4103      +26     
  Branches      190      193       +3     
==========================================
+ Hits         2974     2996      +22     
- Misses        913      914       +1     
- Partials      190      193       +3     
Flag Coverage Δ
api 66.44% <86.20%> (+0.18%) ⬆️
core 79.76% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/api/graphql/translate/dictionary.clj 86.00% <86.20%> (-0.67%) ⬇️
core/src/acc_text/nlg/core.clj 96.15% <87.50%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a322f9b...9186327. Read the comment docs.

@rokasramas rokasramas force-pushed the extend-dictionary-item-schema branch from e2b472c to b335511 Compare March 17, 2021 10:17
@rokasramas rokasramas merged commit 4becb30 into master Mar 18, 2021
@rokasramas rokasramas deleted the extend-dictionary-item-schema branch March 18, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants