[clang] Fix warnings related to enum in clang::PointerAuthQualifier
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to location in clang/include/clang/AST/Type.h header, the following
warnings cluttered the build log and made identifying other meaningful
compiler messages hard.
Warning 1:
```
/path/to/llvm-project/clang/include/clang/AST/Type.h:182:77: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
180 | static_assert((EnabledMask + AddressDiscriminatedMask +
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
181 | AuthenticationModeMask + IsaPointerMask +
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
182 | AuthenticatesNullValuesMask + KeyMask + DiscriminatorMask) ==
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
183 | 0xFFFFFFFF,
| ~~~~~~~~~~
```
Warning 2:
```
/path/to/llvm-project/clang/include/clang/AST/Type.h:196:38: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
196 | (isAddressDiscriminated ? AddressDiscriminatedMask : 0) |
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
|
@ahmedbougacha Likely would make sense to do this in your branch |
asl
approved these changes
Feb 26, 2024
kovdan01
added a commit
that referenced
this pull request
Mar 7, 2024
Includes changes from the following commits from the branch https://github.com/ahmedbougacha/llvm-project/tree/eng/arm64e-upstream-llvmorg - Initial support ahmedbougacha/llvm-project@cc7ba7e - ObjC isa signing ahmedbougacha/llvm-project@c9ce0d4 Also applies a fix from #75 Co-authored-by: Ahmed Bougacha <ahmed@bougacha.org>
kovdan01
added a commit
to kovdan01/llvm-project
that referenced
this pull request
Mar 7, 2024
Includes changes from the following commits from the branch https://github.com/ahmedbougacha/llvm-project/tree/eng/arm64e-upstream-llvmorg - Initial support ahmedbougacha@cc7ba7e - ObjC isa signing ahmedbougacha@c9ce0d4 Also applies a fix from access-softek/llvm-project#75 Co-authored-by: Ahmed Bougacha <ahmed@bougacha.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to location in clang/include/clang/AST/Type.h header, the following warnings cluttered the build log and made identifying other meaningful compiler messages hard.
Warning 1:
Warning 2: