docs(api-admin): add add-user method description | openapi docs #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACC-61 Добавление пользователя в приложение
Отправляем application id, user id, возвращает успех или нет (описать варианты ошибок). Пользователь не может зарегистрироваться в приложении дважды, но может быть зарегистрирован не входив ни разу |
sergeysova
requested changes
Jun 25, 2021
api-admin/openapi.yaml
Outdated
| enum: | ||
| - access_denied | ||
| - invalid_request | ||
| - temporarily_unavailable |
There was a problem hiding this comment.
Для этой ошибки есть отдельный статус 500
| - user_not_found | ||
| - unauthenticated_user | ||
| - unauthorized_client | ||
| redirectUri: |
api-admin/openapi.yaml
Outdated
| description: User should be redirected to if passed redirectUri and clientId is correct | ||
| type: string | ||
| format: url | ||
| state: |
api-admin/openapi.yaml
Outdated
| application/json: | ||
| schema: | ||
| required: | ||
| - error |
There was a problem hiding this comment.
Обязательное поле error, но поля такого нет, есть code
api-admin/openapi.yaml
Outdated
| - application_not_found | ||
| - user_not_found | ||
| - unauthenticated_user | ||
| - unauthorized_client |
There was a problem hiding this comment.
Думаю, такой ошибки не будет
sergeysova
approved these changes
Jun 26, 2021
sergeysova
pushed a commit
that referenced
this pull request
Jul 7, 2021
docs(api-admin): fix path docs(api-admin): fix review comments docs(api-admin): fix review comments docs(api-admin): fix error description Create linear-linker.yml docs(api-admin): add add-user method description | openapi docs (#37) fix(api-admin): naming, remove example method merged manually #39 Closes #39 fix docs(api-admin): add delete user method description | openapi docs (#36) * docs(api-admin): add delete user method description | openapi docs * docs(api-admin): fix review comments * docs(api-admin): fix review * docs(api-admin): typo fixes * docs(api-admin): fix error description Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание контракта для ручки Добавления пользователя в приложение. Задача -> https://linear.app/atomix/issue/ACC-61/dobavlenie-polzovatelya-v-prilozhenie