Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove src param from istrue and error_happens methods #10

Open
accmltr opened this issue Apr 28, 2023 · 1 comment
Open

Remove src param from istrue and error_happens methods #10

accmltr opened this issue Apr 28, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
Play Mode Testing

Comments

@accmltr
Copy link
Owner

accmltr commented Apr 28, 2023 •
edited
Loading

Remove the src param in the methods of testing.gd and user_test.gd. Use the built in get_stack() method in Godot 4 instead of requiring users to provide a source for errors manually!

The constructor and src property in simple_error.gd will also need to be changed accordingly.
@accmltr accmltr added the enhancement New feature or request label Apr 28, 2023
@accmltr
Copy link
Owner Author

accmltr commented May 1, 2023

The get_stack() method does not print the stack when called from an editor script.

@accmltr accmltr added this to the Release v2.0.0 milestone May 1, 2023
@accmltr accmltr mentioned this issue May 1, 2023
Closed
@accmltr accmltr removed this from the Release v2.0.0 milestone May 2, 2023
@accmltr accmltr added this to the Play Mode Testing milestone May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Play Mode Testing
Development

No branches or pull requests
1 participant
@accmltr