Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneccesary parameter In UnitTest's methods #5

Closed
accmltr opened this issue Apr 28, 2023 · 3 comments
Closed

Remove unneccesary parameter In UnitTest's methods #5

accmltr opened this issue Apr 28, 2023 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@accmltr
Copy link
Owner

accmltr commented Apr 28, 2023

The src param in the istrue(..) and error_happens(..) methods of the UnitTest class is not neccesary, since the source of the message can automatically specified by the method bodies when calling the actual implementations of these methods on the Testing singelton.

@accmltr accmltr added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 28, 2023
@accmltr accmltr changed the title Remove Unneccesary Parameter In UnitTest's Methods Remove unneccesary parameter In UnitTest's methods Apr 28, 2023
@accmltr
Copy link
Owner Author

accmltr commented Apr 29, 2023

This would be a breaking change to the API, and should thus be added to the next major version of the plugin in the v2-development branch.

@accmltr accmltr added v2 and removed v2 labels Apr 29, 2023
@accmltr accmltr added this to the Release v2.0.0 milestone Apr 29, 2023
@accmltr
Copy link
Owner Author

accmltr commented May 1, 2023

This issue now falls under the scope of issue #10.

@accmltr accmltr closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
@accmltr
Copy link
Owner Author

accmltr commented May 1, 2023

Issue #10 might take longer than expected to resolve, so this issue will be opened again as an improvement on the interface for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant