Merge pull request #81 from niels-nijens/improve-create-workspace-task

Improvements to CreateWorkspaceTask
accompli · Dec 15, 2015 · dba7088 · dba7088
2 parents ca24e31 + b6dfd4a
commit dba7088
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Task/CreateWorkspaceTask.php b/src/Task/CreateWorkspaceTask.php
@@ -55,6 +55,9 @@ public static function getSubscribedEvents()
                 array('onPrepareWorkspaceConstructWorkspaceInstance', 10),
                 array('onPrepareWorkspaceCreateWorkspace', 0),
             ),
+            AccompliEvents::GET_WORKSPACE => array(
+                array('onPrepareWorkspaceConstructWorkspaceInstance', 10),
+            ),
         );
     }
 
@@ -127,13 +130,13 @@ public function onPrepareWorkspaceCreateWorkspace(WorkspaceEvent $event, $eventN
         foreach ($directories as $directory) {
             $context = array('directory' => $directory, 'event.task.action' => TaskInterface::ACTION_IN_PROGRESS);
 
-            $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::INFO, 'Creating directory "{directory}".', $eventName, $this, $context));
+            $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::DEBUG, 'Creating directory "{directory}".', $eventName, $this, $context));
             if ($connection->isDirectory($directory) === false) {
                 if ($connection->createDirectory($directory)) {
                     $context['event.task.action'] = TaskInterface::ACTION_COMPLETED;
                     $context['output.resetLine'] = true;
 
-                    $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::INFO, 'Created directory "{directory}".', $eventName, $this, $context));
+                    $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::DEBUG, 'Created directory "{directory}".', $eventName, $this, $context));
                 } else {
                     $context['event.task.action'] = TaskInterface::ACTION_FAILED;
                     $context['output.resetLine'] = true;
@@ -144,7 +147,7 @@ public function onPrepareWorkspaceCreateWorkspace(WorkspaceEvent $event, $eventN
                 $context['event.task.action'] = TaskInterface::ACTION_COMPLETED;
                 $context['output.resetLine'] = true;
 
-                $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::INFO, 'Directory "{directory}" exists.', $eventName, $this, $context));
+                $eventDispatcher->dispatch(AccompliEvents::LOG, new LogEvent(LogLevel::DEBUG, 'Directory "{directory}" exists.', $eventName, $this, $context));
             }
         }
     }

diff --git a/tests/Task/CreateWorkspaceTaskTest.php b/tests/Task/CreateWorkspaceTaskTest.php
@@ -16,12 +16,13 @@
 class CreateWorkspaceTaskTest extends PHPUnit_Framework_TestCase
 {
     /**
-     * Tests if CreateWorkspaceTask::getSubscribedEvents returns an array with at least a AccompliEvents::PREPARE_WORKSPACE key.
+     * Tests if CreateWorkspaceTask::getSubscribedEvents returns an array with at least a AccompliEvents::PREPARE_WORKSPACE and AccompliEvents::GET_WORKSPACE key.
      */
     public function testGetSubscribedEvents()
     {
         $this->assertInternalType('array', CreateWorkspaceTask::getSubscribedEvents());
         $this->assertArrayHasKey(AccompliEvents::PREPARE_WORKSPACE, CreateWorkspaceTask::getSubscribedEvents());
+        $this->assertArrayHasKey(AccompliEvents::GET_WORKSPACE, CreateWorkspaceTask::getSubscribedEvents());
     }
 
     /**