Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link #324

Closed
a4aditya opened this issue Mar 2, 2020 · 9 comments · Fixed by #376
Closed

Broken link #324

a4aditya opened this issue Mar 2, 2020 · 9 comments · Fixed by #376
Assignees
Labels
Type: Bug 🐛 Something isn't working

Comments

@a4aditya
Copy link

a4aditya commented Mar 2, 2020

The link for Cicero Documentation on all of the Template Documentations is broken.
Link to the Page: https://templates.accordproject.org/acceptance-of-delivery@0.13.1.html (url)
1

2

Previous link : https://docs.accordproject.org/docs/cicero.html
The new link should be: https://docs.accordproject.org/docs/started-installation.html

what is your suggestion @irmerk @jeromesimeon what should be the new link for the Cicero Documenation Reference?

@irmerk irmerk added the Type: Bug 🐛 Something isn't working label Mar 2, 2020
@irmerk
Copy link
Member

irmerk commented Mar 2, 2020

Good catch. I believe https://docs.accordproject.org/docs/started-hello would be the best link maybe.

@a4aditya
Copy link
Author

a4aditya commented Mar 2, 2020

thanks for the input I'll change the link now and will send a pull request

@jeromesimeon
Copy link
Member

Good catch. I believe https://docs.accordproject.org/docs/started-hello would be the best link maybe.

Good catch indeed. I don't think that link corresponds to the text though?

@jeromesimeon
Copy link
Member

Either update the text or use this link I think: https://docs.accordproject.org/docs/tutorial-nodejs.html

(I would prefer the former)

@jeromesimeon
Copy link
Member

This should be fixed in the templates: https://github.com/accordproject/cicero-template-library/tree/master/views

@a4aditya
Copy link
Author

a4aditya commented Mar 2, 2020

I have changed the link and pushing the changes please review.

@Aniruddha-Shriwant
Copy link
Contributor

@jeromesimeon I'm willing to work on this

@dinuka-rp
Copy link

dinuka-rp commented Mar 12, 2021

@jeromesimeon I was just pointing out this issue in the tech docs. Didn't know that it was generated within this repository till @mttrbrts pointed it out.

Will be willing to get assigned and submit a PR on this issue as recommended by Matt or by updating the developers.njk template file and rebuilding.

Since @Aniruddha-Shriwant was here before me, I guess he can take a shot at the fix first :)

@Aniruddha-Shriwant
Copy link
Contributor

Aniruddha-Shriwant commented Mar 16, 2021

This should be fixed in the templates: https://github.com/accordproject/cicero-template-library/tree/master/views

@jeromesimeon I had changed .\views\developers.njk and then npm run build but when I open any of the HTML files from build\ I found that the issue was not fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants