Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json conflicts and missing tests for new templates in Turkish and Russian #99

Closed
jeromesimeon opened this issue Aug 2, 2018 · 3 comments
Closed

package.json conflicts and missing tests for new templates in Turkish and Russian #99

jeromesimeon opened this issue Aug 2, 2018 · 3 comments
Assignees
@jeromesimeon
Labels
Type: Bug 🐛 Something isn't working

Comments

@jeromesimeon
Copy link
Member

jeromesimeon commented Aug 2, 2018 •
edited
Loading

Some of the new *-tr and *-ru templates have the same package.json file which confuses the scripts creating the archive.

Also it might be good to haves JavaScript tests for those new templates.
@jeromesimeon jeromesimeon added the Type: Bug 🐛 Something isn't working label Aug 2, 2018
@jeromesimeon jeromesimeon self-assigned this Aug 2, 2018
@jeromesimeon
Copy link
Member Author

I'm assigning myself 😅 FYI @dselman @dlkconsultancy

@jeromesimeon
Copy link
Member Author

Fixed in PR #100
leaving the issue open for review

@jeromesimeon
Copy link
Member Author

I'll assume everyone is happy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromesimeon jeromesimeon

Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeromesimeon