Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Add API call for contract state type to template ; Upgrade … #138

Merged
merged 2 commits into from Jun 22, 2018

Conversation

jeromesimeon
Copy link
Member

…to Ergo 0.0.67

Signed-off-by: Jerome Simeon jeromesimeon@me.com

@coveralls
Copy link

coveralls commented Jun 21, 2018

Coverage Status

Coverage increased (+0.1%) to 93.187% when pulling cc886d1 on jeromesimeon:js-feature-issue-137 into bdfe991 on accordproject:master.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like getRequest/Response/Emit/State types are identical except for an index. Can we refactor please to remove the duplicate code?

@@ -276,6 +276,26 @@ describe('Template', () => {

});

describe('#getStateTypes', () => {

it('should return default emit type for single accordclauselogic function', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? emit should be state?

]);
});

it('should return emit type for single accordclauselogic function', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Some typos and not very DRY.

@jeromesimeon
Copy link
Member Author

Fixes typos, descriptions and added tests for no-logic. Might want to consider #140 down the road to replace a lot of that code.

…to Ergo 0.0.67

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@dselman dselman merged commit 9d8b385 into accordproject:master Jun 22, 2018
@jeromesimeon jeromesimeon deleted the js-feature-issue-137 branch June 22, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants