New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) Add API call for contract state type to template ; Upgrade … #138
(feature) Add API call for contract state type to template ; Upgrade … #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like getRequest/Response/Emit/State types are identical except for an index. Can we refactor please to remove the duplicate code?
@@ -276,6 +276,26 @@ describe('Template', () => { | |||
|
|||
}); | |||
|
|||
describe('#getStateTypes', () => { | |||
|
|||
it('should return default emit type for single accordclauselogic function', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? emit should be state?
]); | ||
}); | ||
|
||
it('should return emit type for single accordclauselogic function', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Some typos and not very DRY.
639c14a
to
810b960
Compare
Fixes typos, descriptions and added tests for no-logic. Might want to consider #140 down the road to replace a lot of that code. |
…to Ergo 0.0.67 Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
810b960
to
cc886d1
Compare
…to Ergo 0.0.67
Signed-off-by: Jerome Simeon jeromesimeon@me.com