Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Logo Missing and Invalid Logo Link #48

Closed
kanav-raina opened this issue Mar 24, 2020 · 4 comments · Fixed by #51
Closed

Logo Missing and Invalid Logo Link #48

kanav-raina opened this issue Mar 24, 2020 · 4 comments · Fixed by #51
Assignees

Comments

@kanav-raina
Copy link

kanav-raina commented Mar 24, 2020

Describe the bug
Logo is not displaying in title bar

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'concerto-ui/packages/concerto-ui-react-demo/public/index.html'
  2. Click on https://accordproject.github.io/concerto/latest/favicon.ico
  3. Now go to the provided link'
  4. You will get this error page

Expected behavior
Logo should be displayed on titlebar

Screenshots
broken_link_in_index_html_file

broken_github_page

@kanav-raina
Copy link
Author

kanav-raina commented Mar 24, 2020

Kindly check this @irmerk and @mttrbrts.
I was not able to change the logo from here but I can add logo through concerto-ui/packages/concerto-ui-react-demo/src/index.html

@kanav-raina
Copy link
Author

kanav-raina commented Mar 25, 2020

I think to add logo in ConcertoUI, I just add the following in head tag to "concerto-ui/packages/concerto-ui-react-demo/src/index.html"

<link rel="shortcut icon" href="https://avatars0.githubusercontent.com/u/29445438?s=200&v=4" >
Should I add logo in title bar to concerto-ui? @irmerk

@kanav-raina
Copy link
Author

Concerto-Ui with logo
concerto_with_logo

Concerto-Ui without logo
concerto_without_logo

@kanav-raina kanav-raina changed the title Invalid Logo Link Logo Missing and Invalid Logo Link Mar 25, 2020
@irmerk
Copy link
Member

irmerk commented Apr 6, 2020

@mttrbrts pinging you on this.

@irmerk irmerk linked a pull request Apr 6, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants