New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Functional API #188
Conversation
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most immediate suggestion: please do the work on top of the release-1.0
branch.
I think we may need the validate method to return a new JS object (we are filling in default values, turning ISO 8601 dates into moment objects, etc). -- Alternatively we could separate those things into two passes: one which changes the data representation (e.g., string to date) the other which validates and only fails/succeeds without changing anything).
I would love if those methods would be functional (i.e., validate would not change the input JSON but construct a new one).
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
I like the idea of releasing this first for
Yes, good idea. Should not be hard to implement. |
Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Dan Selman <danscode@selman.org>
Already merged into release-1.0 branch. |
Signed-off-by: Dan Selman danscode@selman.org
Issue #187
Create a functional API for concerto objects.
Changes
Flags
Related Issues