Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions and events should have a timestamp field #23

Closed
dselman opened this issue Oct 29, 2018 · 1 comment
Closed

Transactions and events should have a timestamp field #23

dselman opened this issue Oct 29, 2018 · 1 comment
Assignees
@dselman
Labels
Type: Bug 🐛 Something isn't working

Comments

@dselman
Copy link
Sponsor Contributor

dselman commented Oct 29, 2018

The loopback visitor assumes that transactions have a timestamp field, while the grammar doesn't impose this (the system model does).

We should automatically add a timestamp field to all transactions.
@dselman dselman added the Type: Bug 🐛 Something isn't working label Oct 29, 2018
@dselman dselman self-assigned this Oct 29, 2018
@dselman dselman mentioned this issue Oct 29, 2018
Merged
@dselman dselman changed the title Transactions should have a timestamp field Transactions and events should have a timestamp field Oct 29, 2018
@dselman
Copy link
Sponsor Contributor Author

dselman commented Oct 30, 2018

Fixed

@dselman dselman closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dselman dselman

Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dselman