Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix graphql api error with apollo subscriptions #1137

Merged
merged 1 commit into from
May 6, 2021

Conversation

pradel
Copy link
Member

@pradel pradel commented May 6, 2021

Fixes #1102 and #843

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2021

🦋 Changeset detected

Latest commit: d1ac82e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@accounts/graphql-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1137 (d1ac82e) into master (217004d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   95.53%   95.49%   -0.05%     
==========================================
  Files          93       93              
  Lines        2150     2152       +2     
  Branches      401      402       +1     
==========================================
+ Hits         2054     2055       +1     
- Misses         94       95       +1     
  Partials        2        2              
Impacted Files Coverage Δ
packages/graphql-api/src/modules/accounts/index.ts 78.26% <ø> (ø)
packages/graphql-api/src/utils/context-builder.ts 90.47% <50.00%> (-4.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217004d...d1ac82e. Read the comment docs.

@pradel pradel merged commit 7726eaf into master May 6, 2021
@pradel pradel deleted the feature/fix-apollo-sub branch May 6, 2021 10:43
@github-actions github-actions bot mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using context: accountsGraphQL.context breaks my subscriptions.
1 participant