Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing await to two-factor unset #1182

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

pradel
Copy link
Member

@pradel pradel commented Oct 19, 2021

Fixes #1181

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2021

🦋 Changeset detected

Latest commit: 39bf5ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@accounts/two-factor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1182 (39bf5ce) into master (83280af) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         106      106           
  Lines        2351     2351           
  Branches      463      463           
=======================================
  Hits         2243     2243           
  Misses        105      105           
  Partials        3        3           
Impacted Files Coverage Δ
packages/two-factor/src/two-factor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83280af...39bf5ce. Read the comment docs.

@pradel pradel merged commit 4b6878f into master Oct 19, 2021
@pradel pradel deleted the feat/missing-await-two-factor branch October 19, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: two-factor still set in db after awaiting unset of totp
1 participant