Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo links in graphql-api package.json #1194

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

zenweasel
Copy link
Contributor

Currently when you go to the page on NPM for this package it points to the old archived version which is confusing when the code actually lives here

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2021

⚠️ No Changeset found

Latest commit: 7ae920f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zenweasel
Copy link
Contributor Author

Tried to follow the instructions for adding a changeset but they didn't work for me

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #1194 (7ae920f) into master (485c5ee) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   95.40%   95.28%   -0.12%     
==========================================
  Files         106      106              
  Lines        2351     2377      +26     
  Branches      463      498      +35     
==========================================
+ Hits         2243     2265      +22     
+ Misses        105      103       -2     
- Partials        3        9       +6     
Impacted Files Coverage Δ
packages/database-redis/src/redis.ts 97.91% <100.00%> (+0.09%) ⬆️
packages/two-factor/src/two-factor.ts 100.00% <100.00%> (ø)
packages/graphql-api/src/modules/accounts/index.ts 71.42% <0.00%> (-5.50%) ⬇️
...ckages/oauth-twitter/src/accounts-oauth-twitter.ts 37.50% <0.00%> (-2.50%) ⬇️
packages/password/src/accounts-password.ts 91.16% <0.00%> (-0.31%) ⬇️
packages/oauth/src/accounts-oauth.ts 88.88% <0.00%> (ø)
packages/server/src/utils/get-first-user-email.ts 100.00% <0.00%> (ø)
...es/rest-express/src/endpoints/password/register.ts 100.00% <0.00%> (ø)
...s/graphql-api/src/utils/authenticated-directive.ts 27.27% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed546c...7ae920f. Read the comment docs.

@pradel pradel changed the title (fix) repo links in package.json fix: repo links in package.json Nov 26, 2021
@pradel pradel changed the title fix: repo links in package.json fix: repo links in graphql-api package.json Nov 26, 2021
@pradel
Copy link
Member

pradel commented Nov 26, 2021

Thanks for the fix, I added the changeset :)

@pradel pradel merged commit a4fd732 into accounts-js:master Nov 26, 2021
@zenweasel zenweasel deleted the fix-link-in-readme branch November 27, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants