Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix on Mongo.createUser and Mongo.createSession on 4.X #1251

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

awatson1978
Copy link
Contributor

Bug fix for #1250

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

🦋 Changeset detected

Latest commit: ae31566

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@accounts/mongo-password Minor
@accounts/mongo-sessions Minor
@accounts/mongo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could please add the changeset and remove the commented line? Will create a new release after it's merged

packages/database-mongo-sessions/src/mongo-sessions.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff983b8) 95.32% compared to head (ae31566) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files         106      106           
  Lines        2396     2396           
  Branches      503      513   +10     
=======================================
  Hits         2284     2284           
  Misses        103      103           
  Partials        9        9           
Impacted Files Coverage Δ
...ages/database-mongo-password/src/mongo-password.ts 100.00% <100.00%> (ø)
...ages/database-mongo-sessions/src/mongo-sessions.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@awatson1978
Copy link
Contributor Author

Okay, I added a changeset. First time I've ever done that, so double check it to make sure it looks right.

Copy link
Member

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please delete the yarn.lock and revert the change made to package.json, then we are good to go!

package.json Outdated Show resolved Hide resolved
@awatson1978
Copy link
Contributor Author

How are we doing on this? Just ran into the error again today, and going through the a local patch instead of deploying this improved version of the library.

@awatson1978
Copy link
Contributor Author

2 weeks later, having to sloppy patch another server. 😞

@awatson1978 awatson1978 requested a review from pradel July 21, 2023 21:48
@pradel pradel merged commit 3f1c494 into accounts-js:master Jul 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants