Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation #58

Merged
merged 9 commits into from Jul 25, 2022
Merged

Conversation

Ilithy
Copy link
Contributor

@Ilithy Ilithy commented Jul 23, 2022

  • Translation of the strings.xml file.

I didn't locate any other files to translate,
if I forgot something, let me know,
thanks.

@lberrymage lberrymage linked an issue Jul 23, 2022 that may be closed by this pull request
@lberrymage
Copy link
Member

cc @Wonderfall

app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
<string name="cant_find_app">Désolé, nous n\'avons pas trouvé cette application</string>
<string name="couldnt_open_app">Impossible d\'ouvrir l\'application</string>
<string name="network_error">Erreur réseau: %1$s</string>
<string name="app_verification_failed">Échec de la vérification de l\'application: %1$s</string>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalement en typographie française on met un espace avant et après le " : "
Mais à voir si cela est désirable ici (même remarque ailleurs), ce n'est pas très grave

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectivement, je préfère sans l'espace, mais c'est comme vous le voulez, cela n'a pas de reel importance (juste un écart peu élégant à mon sens), je n'ai actuellement rien modifier.

app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
@lberrymage
Copy link
Member

lberrymage commented Jul 24, 2022

A few strings were added in 390c186 if you wouldn't mind adding them to this PR.

@Ilithy
Copy link
Contributor Author

Ilithy commented Jul 24, 2022

A few strings were added in 390c186 if you wouldn't mind adding them to this PR.

Done 👍

@Wonderfall , please check my changes, thanks 🙏

app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
@lberrymage
Copy link
Member

Looks good. Go ahead and fix the build error and I'll squash and merge.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lberrymage
Copy link
Member

Awesome! Thanks for adding the translation!

@lberrymage lberrymage merged commit 5642d34 into accrescent:master Jul 25, 2022
@Ilithy Ilithy deleted the add-french-translation branch July 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Translation of UI
3 participants