-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french translation #58
Conversation
cc @Wonderfall |
<string name="cant_find_app">Désolé, nous n\'avons pas trouvé cette application</string> | ||
<string name="couldnt_open_app">Impossible d\'ouvrir l\'application</string> | ||
<string name="network_error">Erreur réseau: %1$s</string> | ||
<string name="app_verification_failed">Échec de la vérification de l\'application: %1$s</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normalement en typographie française on met un espace avant et après le " : "
Mais à voir si cela est désirable ici (même remarque ailleurs), ce n'est pas très grave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effectivement, je préfère sans l'espace, mais c'est comme vous le voulez, cela n'a pas de reel importance (juste un écart peu élégant à mon sens), je n'ai actuellement rien modifier.
A few strings were added in 390c186 if you wouldn't mind adding them to this PR. |
Done 👍 @Wonderfall , please check my changes, thanks 🙏 |
Looks good. Go ahead and fix the build error and I'll squash and merge. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Awesome! Thanks for adding the translation! |
I didn't locate any other files to translate,
if I forgot something, let me know,
thanks.