-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme changes #5
Conversation
|
||
``` | ||
git clone https://github.com/accuknox/accuknox-cli.git | ||
cd kubearmor-client | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove make install? there is already a install script, can't you update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharmayajush Can you also check where karmor are used in the codebase and update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Update karmor to accuknox-cli - Update readme
* fix(logClient.go):fix panic interface conversion: interface {} is nil, not string Signed-off-by: 晓杰 <2561589453@qq.com> * Revert "chores(accuknox-cli): update karmor to accuknox-cli" Signed-off-by: sahil <sahilraja242@gmail.com> * feat: Connect with discovery-engine to recommend Kyverno policies Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * Upgraded github.com/kubearmor/KubeArmor/protobuf to latest Signed-off-by: stefin <stefin.shaji@accuknox.com> * chore: Bump go version and dependency versions Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * karmor security HTML report fix Signed-off-by: Vishnu Soman <vishnu@accuknox.com> * add kubearmor configmap installation Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> * fix: Fix order of policy report generation Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * get uuid (#1) minor changes * feat(license): intall license command(#2) Install license command * chores(readme): update (#5) - Update karmor to accuknox-cli - Update readme * license-status (#3) * fix(license): update license commands (#6) - update license subcommands * feat(install): install discovery engine (#7) - install disovery engine * Update install.sh * chores(sync): sync repo Signed-off-by: sahil <sahilraja242@gmail.com> --------- Signed-off-by: 晓杰 <2561589453@qq.com> Signed-off-by: sahil <sahilraja242@gmail.com> Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> Signed-off-by: stefin <stefin.shaji@accuknox.com> Signed-off-by: Vishnu Soman <vishnu@accuknox.com> Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: 晓杰 <2561589453@qq.com> Co-authored-by: Vyom-Yadav <jackhammervyom@gmail.com> Co-authored-by: Rahul Jadhav <nyrahul@gmail.com> Co-authored-by: stefin <112696367+stefin9898@users.noreply.github.com> Co-authored-by: Vishnu Soman <vishnu@accuknox.com> Co-authored-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: Barun Acharya <barun.acharya@accuknox.com> Co-authored-by: sharmayajush <124571729+sharmayajush@users.noreply.github.com>
* fix(logClient.go):fix panic interface conversion: interface {} is nil, not string Signed-off-by: 晓杰 <2561589453@qq.com> * Revert "chores(accuknox-cli): update karmor to accuknox-cli" Signed-off-by: sahil <sahilraja242@gmail.com> * feat: Connect with discovery-engine to recommend Kyverno policies Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * Upgraded github.com/kubearmor/KubeArmor/protobuf to latest Signed-off-by: stefin <stefin.shaji@accuknox.com> * chore: Bump go version and dependency versions Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * karmor security HTML report fix Signed-off-by: Vishnu Soman <vishnu@accuknox.com> * add kubearmor configmap installation Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> * fix: Fix order of policy report generation Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * get uuid (#1) minor changes * feat(license): intall license command(#2) Install license command * chores(readme): update (#5) - Update karmor to accuknox-cli - Update readme * license-status (#3) * fix(license): update license commands (#6) - update license subcommands * feat(install): install discovery engine (#7) - install disovery engine * Update install.sh * chores(sync): sync repo Signed-off-by: sahil <sahilraja242@gmail.com> --------- Signed-off-by: 晓杰 <2561589453@qq.com> Signed-off-by: sahil <sahilraja242@gmail.com> Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> Signed-off-by: stefin <stefin.shaji@accuknox.com> Signed-off-by: Vishnu Soman <vishnu@accuknox.com> Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: 晓杰 <2561589453@qq.com> Co-authored-by: Vyom-Yadav <jackhammervyom@gmail.com> Co-authored-by: Rahul Jadhav <nyrahul@gmail.com> Co-authored-by: stefin <112696367+stefin9898@users.noreply.github.com> Co-authored-by: Vishnu Soman <vishnu@accuknox.com> Co-authored-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: Barun Acharya <barun.acharya@accuknox.com> Co-authored-by: sharmayajush <124571729+sharmayajush@users.noreply.github.com>
* fix(logClient.go):fix panic interface conversion: interface {} is nil, not string Signed-off-by: 晓杰 <2561589453@qq.com> * Revert "chores(accuknox-cli): update karmor to accuknox-cli" Signed-off-by: sahil <sahilraja242@gmail.com> * feat: Connect with discovery-engine to recommend Kyverno policies Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * Upgraded github.com/kubearmor/KubeArmor/protobuf to latest Signed-off-by: stefin <stefin.shaji@accuknox.com> * chore: Bump go version and dependency versions Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * karmor security HTML report fix Signed-off-by: Vishnu Soman <vishnu@accuknox.com> * add kubearmor configmap installation Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> * fix: Fix order of policy report generation Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> * get uuid (#1) minor changes * feat(license): intall license command(#2) Install license command * chores(readme): update (#5) - Update karmor to accuknox-cli - Update readme * license-status (#3) * fix(license): update license commands (#6) - update license subcommands * feat(install): install discovery engine (#7) - install disovery engine * Update install.sh * chores(sync): sync repo Signed-off-by: sahil <sahilraja242@gmail.com> * chores(sync): fix repo Signed-off-by: sahil <sahilraja242@gmail.com> * chores(sync): fix repo Signed-off-by: sahil <sahilraja242@gmail.com> --------- Signed-off-by: 晓杰 <2561589453@qq.com> Signed-off-by: sahil <sahilraja242@gmail.com> Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com> Signed-off-by: stefin <stefin.shaji@accuknox.com> Signed-off-by: Vishnu Soman <vishnu@accuknox.com> Signed-off-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: 晓杰 <2561589453@qq.com> Co-authored-by: Vyom-Yadav <jackhammervyom@gmail.com> Co-authored-by: Rahul Jadhav <nyrahul@gmail.com> Co-authored-by: stefin <112696367+stefin9898@users.noreply.github.com> Co-authored-by: Vishnu Soman <vishnu@accuknox.com> Co-authored-by: Rudraksh Pareek <rudraksh@accuknox.com> Co-authored-by: Barun Acharya <barun.acharya@accuknox.com> Co-authored-by: sharmayajush <124571729+sharmayajush@users.noreply.github.com>
signed-off-by: Yajush Sharma yajush@accuknox.com