- Fixing Go-sec issue

- By fixing defer & directory permission Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
accuknox · Feb 7, 2023 · a194ba8 · a194ba8
1 parent f437049
commit a194ba8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/cluster/clusterMgmtHandler.go b/src/cluster/clusterMgmtHandler.go
@@ -91,7 +91,7 @@ func getResponseBytes(method string, url string, data map[string]interface{}) []
 	dumpHttpClient(nil, resp)
 	defer func() {
 		if err := resp.Body.Close(); err != nil {
-			log.Error().Msgf("Error closing http stream %s\n", err)
+			log.Warn().Msgf("Error closing http stream %s\n", err)
 		}
 	}()
 

diff --git a/src/cluster/kvmServiceHandler.go b/src/cluster/kvmServiceHandler.go
@@ -25,7 +25,7 @@ func GetResourcesFromKvmService() ([]string, []types.Pod) {
 	}
 	defer func() {
 		if err := resp.Body.Close(); err != nil {
-			log.Error().Msgf("Error closing http stream %s\n", err)
+			log.Warn().Msgf("Error closing http stream %s\n", err)
 		}
 	}()
 

diff --git a/src/logging/logger.go b/src/logging/logger.go
@@ -53,7 +53,7 @@ func configure(config Config) *zerolog.Logger {
 }
 
 func newRollingFile(config Config) io.Writer {
-	if err := os.MkdirAll(config.Directory, 0744); err != nil {
+	if err := os.MkdirAll(config.Directory, 0700); err != nil {
 		log.Error().Err(err).Str("path", config.Directory).Msg("can't create log directory")
 		return nil
 	}

diff --git a/src/recommendpolicy/downloadTemplates.go b/src/recommendpolicy/downloadTemplates.go
@@ -159,7 +159,7 @@ func unZip(source, dest string) error {
 		}
 		defer func() {
 			if err := open.Close(); err != nil {
-				log.Error().Msgf("Error closing file %s\n", err)
+				log.Warn().Msgf("Error closing file %s\n", err)
 			}
 		}()
 	}