Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream policy updates to GRPC clients #556

Merged
merged 2 commits into from Sep 23, 2022
Merged

Stream policy updates to GRPC clients #556

merged 2 commits into from Sep 23, 2022

Conversation

wazir-ahmed
Copy link
Contributor

  • Added new GPRC service to stream policy updates
  • The service will stream both KubeArmor and Cilium policy updates.

@wazir-ahmed wazir-ahmed changed the title Stream policy Stream policy updates to GRPC clients Sep 16, 2022
@wazir-ahmed wazir-ahmed force-pushed the stream-policy branch 2 times, most recently from 57bbeea to 5affa3a Compare September 16, 2022 10:57
seswarrajan
seswarrajan approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wazir-ahmed
Added new GPRC service to stream policy updates
cdb0806 
Signed-off-by: Wazir Ahmed <wazir@accuknox.com>
@wazir-ahmed wazir-ahmed force-pushed the stream-policy branch 2 times, most recently from 9d29f3a to 3f2570f Compare September 20, 2022 09:34
seswarrajan
seswarrajan approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@seswarrajan seswarrajan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nyrahul Please provide your comments.

@seswarrajan
Copy link
Contributor

@wazir-ahmed
Please remove lines as well, since the cluster_name and container_name is removed from source.
https://github.com/kubearmor/discovery-engine/blob/797e6b4fbd027ef0938a9d5a4ec6b9c26c9cd9be/src/systempolicy/systemPolicy.go#L326

@seswarrajan seswarrajan reopened this Sep 20, 2022
@wazir-ahmed
Copy link
Contributor Author

@wazir-ahmed Please remove lines as well, since the cluster_name and container_name is removed from source.

https://github.com/kubearmor/discovery-engine/blob/797e6b4fbd027ef0938a9d5a4ec6b9c26c9cd9be/src/systempolicy/systemPolicy.go#L326

@seswarrajan Fixed this as well.

nyrahul
nyrahul approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few minor comments.

src/networkpolicy/consumer.go Outdated Show resolved Hide resolved
src/libs/consumer.go Outdated Show resolved Hide resolved
src/protobuf/v1/discovery/discovery.proto Outdated Show resolved Hide resolved
@wazir-ahmed
Implementation of GPRC policy updates streaming
62aa428 
Signed-off-by: Wazir Ahmed <wazir@accuknox.com>
@nyrahul nyrahul merged commit 4c6f445 into accuknox:dev Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyrahul nyrahul nyrahul approved these changes

@seswarrajan seswarrajan seswarrajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wazir-ahmed @seswarrajan @nyrahul