Recommend host hardening policies #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnusomank
force-pushed
the
host-policy
branch
from
ac04b61
to
dfc73a5
Compare
seswarrajan
requested changes
Feb 6, 2023
vishnusomank
force-pushed
the
host-policy
branch
from
dfc73a5
to
e9a7c7a
Compare
|
@vishnusomank Please fix gosec issues |
vishnusomank
force-pushed
the
host-policy
branch
from
e9a7c7a
to
cb3b747
Compare
seswarrajan
approved these changes
Feb 7, 2023
yes this was tested locally on a k3s cluster @seswarrajan |
achrefbensaad
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Can you please fix lint error. else LGTM!
For some reason I can't add code comments.
https://github.com/accuknox/discovery-engine/pull/662/files#diff-e482c14daf9bbc77d728fa6a131912cb553e5652f4f31572b6c6da87ae148d4cR1
vishnusomank
force-pushed
the
host-policy
branch
from
cb3b747
to
9752084
Compare
seswarrajan
reviewed
Feb 13, 2023
|
Kindly resolve conflicts and update. |
- show KubearmorHostPolicies while recommending hardening policies based on flag value Signed-off-by: Vishnu Soman <vishnu@accuknox.com>
vishnusomank
force-pushed
the
host-policy
branch
from
9752084
to
02c2c7b
Compare
@seswarrajan i've resolved the conflicts and updated. kindly review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vishnu Soman vishnu@accuknox.com