removing namespace dependency of kubearmor for discovery-engine #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
Prateeknandle
force-pushed
the
ns_dependency
branch
2 times, most recently
from
71cbd8f
to
b0197cb
Compare
daemon1024
requested changes
Feb 23, 2023
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
Prateeknandle
force-pushed
the
ns_dependency
branch
from
07e4c31
to
b154986
Compare
daemon1024
approved these changes
Feb 23, 2023
nyrahul
approved these changes
Feb 24, 2023
|
@Prateeknandle Have we verified these changes? Like if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #660
after this discovery-engine will be able to detect kubearmor from any namespace, right noe it only detect kubearmor if it is deployed in
kube-systemnamespace.changes:
kube-system, then we will get the namespace in which it is deployed and then connect discovery-engine with new configurations.