New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(license): add license feature #702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rajaSahil
commented
Apr 3, 2023
•
edited
edited
- Add License feature
- Add protobuf for licensing
rajaSahil
changed the title
[WIP] feat(license): add protobuf for license
feat(license): add license feature
Apr 9, 2023
rajaSahil
force-pushed
the
feat-license
branch
7 times, most recently
from
April 11, 2023 09:13
b467c68
to
f324e3e
Compare
rajaSahil
commented
Apr 11, 2023
nyrahul
requested changes
Apr 11, 2023
vishnusomank
requested changes
Apr 12, 2023
rajaSahil
force-pushed
the
feat-license
branch
2 times, most recently
from
April 12, 2023 10:12
ffb8f3c
to
398bfed
Compare
vishnusomank
approved these changes
Apr 12, 2023
nyrahul
requested changes
Apr 12, 2023
nyrahul
requested changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few comments from my past reviews that are not handled. Or am i mistaken?
nyrahul
requested changes
Apr 17, 2023
#702 (comment) But assignment only happens if ValidateLicense() doesn't throw any error. |
Signed-off-by: sahil <sahilraja242@gmail.com>
nyrahul
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.