Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(license): add license feature #702

Merged
merged 1 commit into from Apr 18, 2023
Merged

Conversation

rajaSahil
Copy link
Collaborator

@rajaSahil rajaSahil commented Apr 3, 2023

  • Add License feature
  • Add protobuf for licensing

@rajaSahil rajaSahil changed the title [WIP] feat(license): add protobuf for license feat(license): add license feature Apr 9, 2023
@rajaSahil rajaSahil marked this pull request as ready for review April 9, 2023 22:16
@rajaSahil rajaSahil requested a review from nyrahul April 9, 2023 22:18
@rajaSahil rajaSahil force-pushed the feat-license branch 7 times, most recently from b467c68 to f324e3e Compare April 11, 2023 09:13
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/license/license.go Show resolved Hide resolved
src/license/license.go Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
src/cluster/k8sClientHandler.go Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/license/license.go Outdated Show resolved Hide resolved
src/main.go Show resolved Hide resolved
src/server/grpcServer_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few comments from my past reviews that are not handled. Or am i mistaken?

src/license/license.go Show resolved Hide resolved
src/cluster/k8sClientHandler.go Outdated Show resolved Hide resolved
@rajaSahil
Copy link
Collaborator Author

#702 (comment) But assignment only happens if ValidateLicense() doesn't throw any error.

Signed-off-by: sahil <sahilraja242@gmail.com>
@rajaSahil rajaSahil merged commit 5c61942 into accuknox:dev Apr 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants