Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting links doesn't work #54

Closed
szopin opened this issue Dec 5, 2019 · 4 comments · Fixed by szopin/Quickddit#1
Closed

Posting links doesn't work #54

szopin opened this issue Dec 5, 2019 · 4 comments · Fixed by szopin/Quickddit#1

Comments

@szopin
Copy link
Contributor

szopin commented Dec 5, 2019

Only selfposts allow submitting

@szopin
Copy link
Contributor Author

szopin commented Dec 5, 2019

Not sure why this got closed, mobile view issue maybe

@szopin szopin reopened this Dec 5, 2019
@accumulator
Copy link
Owner

accumulator commented Dec 7, 2019

Thanks for noticing this! It's a regression that appears on subreddits that have no flairs.

Your patch however could be even shorter. The check for subredditsFlair.length should I think be totally removed, and the check for linkTitle.text.length is already satisfied one line above.

Could you change the line to

&& ((selfLinkSwitch.checked && linkDescription.text.length > 0) || (!selfLinkSwitch.checked && linkUrl.acceptableInput))

@szopin
Copy link
Contributor Author

szopin commented Dec 7, 2019

Updated, didn't want to touch the flair part as still never seen this feature in action, so no idea how that works, for normal subreddits checked and the submit button does light up now as expected, thanks!

@accumulator
Copy link
Owner

Merged, thanks.

Flair is a bit complex, there are subreddits that allow you to choose from a list (which is implemented in Quickddit) and there are subreddits where you can enter custom flair text (not implemented). The flair part in the button enable check was to allow choosing a new flair and submit, but that broke the button for subreddits without a flair list. So, corner case but good find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants