Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform iac provider should proceed with static analysis when rootMod is not nil #1211

Merged
merged 1 commit into from Mar 31, 2022
Merged

terraform iac provider should proceed with static analysis when rootMod is not nil #1211

merged 1 commit into from Mar 31, 2022

Conversation

patilpankaj212
Copy link
Contributor

@patilpankaj212 patilpankaj212 commented Mar 31, 2022 •
edited

fixes #1182
fixes #1176

@patilpankaj212 patilpankaj212 requested a review from a team as a code owner March 31, 2022 10:43
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1211 (4054a49) into master (d818b60) will decrease coverage by 0.09%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
- Coverage   77.92%   77.83%   -0.10%     
==========================================
  Files         272      272              
  Lines        7634     7642       +8     
==========================================
- Hits         5949     5948       -1     
- Misses       1337     1344       +7     
- Partials      348      350       +2
Impacted Files Coverage Δ
pkg/iac-providers/terraform/commons/load-dir.go 75.22% <80.00%> (-3.28%) ⬇️

Rchanger
Rchanger approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@Rchanger Rchanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rchanger Rchanger merged commit 655761a into tenable:master Mar 31, 2022
@szwed szwed mentioned this pull request May 18, 2022
Open
@leadenmoth leadenmoth mentioned this pull request Mar 10, 2023
Closed
@leadenmoth leadenmoth mentioned this pull request Mar 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rchanger Rchanger Rchanger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocks of type "moved" not supported Can't parse Terraform variable field: nullable
2 participants
@patilpankaj212 @Rchanger