Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Option to provide temp directory path for download #1214

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

Rchanger
Copy link
Contributor

@Rchanger Rchanger commented Apr 1, 2022

Changes to read environment variable TERRRASCAN_CUSTOM_TEMP_DIR to specify a temporary directory to download repository, terraform modules, and cft/arm templates.

@Rchanger Rchanger requested review from a team and bkizer-tenable as code owners April 1, 2022 07:52
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1214 (99e7b1b) into master (a59fc2b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1214   +/-   ##
=======================================
  Coverage   77.77%   77.78%           
=======================================
  Files         272      272           
  Lines        7675     7678    +3     
=======================================
+ Hits         5969     5972    +3     
  Misses       1353     1353           
  Partials      353      353           
Impacted Files Coverage Δ
pkg/cli/run.go 88.23% <100.00%> (ø)
pkg/http-server/remote-repo.go 71.83% <100.00%> (ø)
...per/iac-providers/arm/functions/linked-template.go 89.47% <100.00%> (ø)
.../mapper/iac-providers/cft/functions/s3-download.go 71.87% <100.00%> (ø)
pkg/utils/dir.go 85.71% <100.00%> (+3.89%) ⬆️

Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@Rchanger Rchanger merged commit 2345a4a into tenable:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants